Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address a11y issues with ActionList, NavList, and ActionMenu #1946

Merged
merged 14 commits into from
Apr 13, 2023
Merged

Address a11y issues with ActionList, NavList, and ActionMenu #1946

merged 14 commits into from
Apr 13, 2023

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Apr 11, 2023 •
edited
Loading

Description

This PR does the following:

  1. Ensures correct roles are attached to items for ActionList, NavList, and ActionMenu.
  2. Fixes Dropdown divider role.
  3. Fixes keyboard navigation for ActionMenu and adds a bunch of system tests for keyboard nav behavior.

Integration

Does this change require any updates to code in production?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 0579860

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Apr 11, 2023
@camertron camertron temporarily deployed to preview April 11, 2023 21:22 — with GitHub Actions Inactive
@camertron camertron temporarily deployed to github-pages April 11, 2023 21:26 — with GitHub Actions Inactive
@camertron camertron temporarily deployed to preview April 11, 2023 21:33 — with GitHub Actions Inactive
@camertron camertron temporarily deployed to github-pages April 11, 2023 21:39 — with GitHub Actions Inactive
@camertron camertron marked this pull request as ready for review April 11, 2023 21:41
@camertron camertron requested review from a team, keithamus, langermank and jonrohan and removed request for a team and keithamus April 11, 2023 21:41
jonrohan
jonrohan approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍🏻

@camertron camertron temporarily deployed to preview April 11, 2023 22:52 — with GitHub Actions Inactive
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Apr 11, 2023
@camertron camertron temporarily deployed to github-pages April 11, 2023 22:58 — with GitHub Actions Inactive
@camertron camertron temporarily deployed to preview April 12, 2023 04:23 — with GitHub Actions Inactive
@camertron camertron temporarily deployed to github-pages April 12, 2023 04:27 — with GitHub Actions Inactive
@camertron camertron temporarily deployed to github-pages April 12, 2023 23:37 — with GitHub Actions Inactive
@camertron camertron changed the title Address NavList Axe violation Address a11y issues with ActionList, NavList, and ActionMenu Apr 13, 2023
@camertron camertron merged commit 62e6056 into main Apr 13, 2023
@camertron camertron deleted the fix_nav_list_axe_violation branch April 13, 2023 22:13
@primer-css primer-css mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank Awaiting requested review from langermank

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code patch release ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camertron @jonrohan